Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [#1809] Regression test for CTA button on product page #817

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Oct 19, 2023

Regression test for the issue that was fixed in #813

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI

@codecov-commenter
Copy link

Codecov Report

Merging #817 (0fea4cc) into develop (3dfa94a) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #817      +/-   ##
===========================================
- Coverage    93.05%   93.02%   -0.04%     
===========================================
  Files          744      744              
  Lines        25931    25950      +19     
===========================================
+ Hits         24130    24139       +9     
- Misses        1801     1811      +10     
Files Coverage Δ
src/open_inwoner/pdc/tests/test_product.py 95.28% <50.00%> (-4.72%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevenbal
Copy link
Contributor Author

Hmmm, how does adding a test cause coverage to go down and another test to fail 🤔

@alextreme
Copy link
Member

The e2e tests seem to be a bit flakey, rerunning

@alextreme alextreme merged commit c2da1ed into develop Oct 26, 2023
14 checks passed
@alextreme alextreme deleted the issue/1809-cta-button-test branch October 26, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants