Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#1809] Fix CTA button on product page #813

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

stevenbal
Copy link
Contributor

No description provided.

@@ -8,7 +8,6 @@ export class ReadMore {
}

toggleReadMore(event) {
event.preventDefault()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alextreme this change was committed three months ago, so this must have been broken for a while?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readmore was added in v1.11, so this would make sense

@codecov-commenter
Copy link

Codecov Report

Merging #813 (608979b) into develop (60b3b15) will increase coverage by 0.00%.
Report is 8 commits behind head on develop.
The diff coverage is 68.75%.

@@           Coverage Diff            @@
##           develop     #813   +/-   ##
========================================
  Coverage    93.04%   93.04%           
========================================
  Files          742      742           
  Lines        25825    25830    +5     
========================================
+ Hits         24029    24034    +5     
  Misses        1796     1796           
Files Coverage Δ
src/open_inwoner/conf/base.py 95.62% <100.00%> (ø)
src/open_inwoner/pdc/tests/test_views.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/views.py 85.19% <100.00%> (+0.05%) ⬆️
src/open_inwoner/ssd/forms.py 96.29% <100.00%> (ø)
src/open_inwoner/ssd/templatetags/ssd_tags.py 95.45% <100.00%> (ø)
src/open_inwoner/ssd/tests/test_forms.py 100.00% <100.00%> (ø)
src/open_inwoner/ssd/tests/test_xml.py 100.00% <ø> (ø)
src/open_inwoner/ssd/xml.py 72.22% <16.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit cdb0a41 into develop Oct 16, 2023
14 checks passed
@alextreme alextreme deleted the issue/1809-cta-button-broken branch October 16, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants