Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [#1789] Add ZaakTypeStatusTypeConfig model #803

Merged
merged 5 commits into from
Oct 19, 2023
Merged

✨ [#1789] Add ZaakTypeStatusTypeConfig model #803

merged 5 commits into from
Oct 19, 2023

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Oct 9, 2023 •
edited
Loading

No description provided.

@stevenbal stevenbal marked this pull request as draft October 9, 2023 10:37
stevenbal
stevenbal commented Oct 9, 2023
View reviewed changes
src/open_inwoner/openzaak/models.py
)

# configuration
status_indicator = models.CharField(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to name this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indicator would have been fine

@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch from 79cc92d to eeac342 Compare October 9, 2023 10:39
@stevenbal stevenbal self-assigned this Oct 12, 2023
@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch 3 times, most recently from 5dea031 to 960a776 Compare October 12, 2023 08:35
@stevenbal
Copy link
Contributor Author

Configuration for the statustypen is shown as an inline in the ZaakTypeConfig admin (I don't fully understand why one ZaakTypeConfig represents multiple zaaktypen UUIDs, but that seemed to be the case already before my changes):

image

For status_indicator success, nothing is shown and for action_required it looks like this:

image

@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch 2 times, most recently from eadc716 to cf0a995 Compare October 12, 2023 10:05
@codecov-commenter
Copy link

Codecov Report

Merging #803 (cf0a995) into develop (64b1b4d) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is 94.44%.

@@           Coverage Diff            @@
##           develop     #803   +/-   ##
========================================
  Coverage    93.05%   93.06%           
========================================
  Files          742      744    +2     
  Lines        25821    25908   +87     
========================================
+ Hits         24028    24110   +82     
- Misses        1793     1798    +5
Files Coverage Δ
src/open_inwoner/cms/cases/views/mixins.py 96.93% <100.00%> (+0.06%) ⬆️
src/open_inwoner/openzaak/admin.py 91.97% <100.00%> (+0.56%) ⬆️
src/open_inwoner/openzaak/constants.py 100.00% <100.00%> (ø)
...er/openzaak/management/commands/zgw_import_data.py 100.00% <100.00%> (ø)
...ner/openzaak/migrations/0025_auto_20231012_1001.py 100.00% <100.00%> (ø)
src/open_inwoner/openzaak/models.py 98.41% <100.00%> (+0.19%) ⬆️
src/open_inwoner/openzaak/tests/test_cases.py 100.00% <ø> (ø)
...inwoner/openzaak/tests/test_zgw_imports_command.py 100.00% <100.00%> (ø)
...inwoner/openzaak/tests/test_zgw_imports_iotypes.py 100.00% <100.00%> (ø)
src/open_inwoner/openzaak/zgw_imports.py 94.48% <86.84%> (-3.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch from cf0a995 to 6ab602a Compare October 12, 2023 10:49
@stevenbal stevenbal changed the title [Draft] ✨ [#1789] Add ZaakTypeStatusTypeConfig model ✨ [#1789] Add ZaakTypeStatusTypeConfig model Oct 12, 2023
@stevenbal stevenbal marked this pull request as ready for review October 12, 2023 10:56
@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch from 6ab602a to b10b402 Compare October 12, 2023 11:01
alextreme
alextreme reviewed Oct 12, 2023
View reviewed changes
src/open_inwoner/openzaak/models.py
verbose_name=_("Statustekst"),
max_length=1000,
)
zaaktype_uuids = ArrayField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is in there as we already have a relation with a zaaktype_config. But as this is done this way for the ZTIOT-Config I guess there is a purpose...

@alextreme
Copy link
Member

indicator options can be expanded, but besides that this PR is good to go in my eyes, nice work.

@stevenbal
Copy link
Contributor Author

Extra options:
image

image

@stevenbal stevenbal force-pushed the feature/1789-status-action-success branch from b10b402 to 3e7fd26 Compare October 16, 2023 09:14
@stevenbal stevenbal mentioned this pull request Oct 16, 2023
Merged
@stevenbal stevenbal merged commit 65f91e3 into develop Oct 19, 2023
14 checks passed
@stevenbal stevenbal deleted the feature/1789-status-action-success branch October 19, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@pi-sigma pi-sigma Awaiting requested review from pi-sigma

Assignees

@stevenbal stevenbal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenbal @codecov-commenter @alextreme