Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1779] Fix alignment of search results #794

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jiromaykin
Copy link
Contributor

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1779
needs filled sidebar or else checkboxes will align weirdly

@codecov-commenter
Copy link

Codecov Report

Merging #794 (20f4385) into develop (f184f94) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #794   +/-   ##
========================================
  Coverage    93.17%   93.17%           
========================================
  Files          721      721           
  Lines        25027    25027           
========================================
  Hits         23318    23318           
  Misses        1709     1709           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin marked this pull request as ready for review October 2, 2023 10:32
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the spacing around the feedback part strange. In particular, the spacing between the question ("Heeft u gevonden wat u zocht?") and the buttons is much larger than that between "Feedback" and the the paginator. See screenshot It would be nice if the elements that belong together logically would also be grouped together visually. However, since this is not the result of your PR, feel free to address this in a separate ticket (or not at all, I'll leave it to you).

Screenshot from 2023-10-02 16-14-39

@jiromaykin
Copy link
Contributor Author

....the spacing between the question ("Heeft u gevonden wat u zocht?") and the buttons is much larger than that between "Feedback" and the the paginator"

No it's actually bigger. - you may have forgotten to do a hard-refresh in your browser?
(after the NPM run watch thing?)
In all my browsers it looks like this in the screenshot: (so maybe: we may need to do something else, like removing space between the thumbs and the question-Paragraph, also @alextreme I am wondering: why don't we want to show the feedback at all if there are zero search results? Shouldn't users have the option to give feedback if they can't find anything?)

Screenshot 2023-10-02 at 16 47 13

@alextreme
Copy link
Member

@jiromaykin I guess it makes sense to always show the feedback form thing, especially when there are no results.

@alextreme alextreme merged commit 7086255 into develop Oct 3, 2023
14 checks passed
@alextreme alextreme deleted the fix/1779-alignment-in-search-page branch October 3, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants