Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#1750] Add meta tags for social media sharing #783

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

stevenbal
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #783 (c901ddb) into develop (09f11b9) will decrease coverage by 0.41%.
Report is 62 commits behind head on develop.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop     #783      +/-   ##
===========================================
- Coverage    93.57%   93.16%   -0.41%     
===========================================
  Files          698      721      +23     
  Lines        24605    25032     +427     
===========================================
+ Hits         23023    23322     +299     
- Misses        1582     1710     +128     
Files Coverage Δ
src/open_inwoner/pdc/views.py 85.18% <80.00%> (-0.10%) ⬇️

... and 41 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding name="description" this can be merged

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss a few basic tags that matter and we have data available for, like og:image and twitter:image (every product has an image), og:url (product.get_absolute_url() eg without random query params) and og:type (hardcoded as 'article')

* Add extra meta tags for sharing (description, image, page and type)
@stevenbal stevenbal force-pushed the feature/1750-sharing-meta-tags branch from 2288fba to c901ddb Compare October 2, 2023 10:54
@alextreme
Copy link
Member

Mag gemerged worden zodra deze groen is

@alextreme alextreme merged commit 084b643 into develop Oct 4, 2023
14 checks passed
@alextreme alextreme deleted the feature/1750-sharing-meta-tags branch October 4, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants