-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#1750] Add meta tags for social media sharing #783
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #783 +/- ##
===========================================
- Coverage 93.57% 93.16% -0.41%
===========================================
Files 698 721 +23
Lines 24605 25032 +427
===========================================
+ Hits 23023 23322 +299
- Misses 1582 1710 +128
... and 41 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding name="description" this can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss a few basic tags that matter and we have data available for, like og:image and twitter:image (every product has an image), og:url (product.get_absolute_url() eg without random query params) and og:type (hardcoded as 'article')
* Add extra meta tags for sharing (description, image, page and type)
2288fba
to
c901ddb
Compare
Mag gemerged worden zodra deze groen is |
No description provided.