[#1756] Make video iFrames responsive #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
feature/1714-styling-video-homepage
branch
from
5fda007
to
8a270b6
Compare
Bartvaderkin
changed the base branch from
develop
to
feature/1714-video-homepage
Bartvaderkin
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Cool. Note I changed the target branch of this PR to be my branch/PR, so we can see the changes you did, review separately but then merge it to the main PR (as together they are one feature).
Github is even so smart it would retarget this PR to develop if we merged the main one first, which is sometimes handy when building and reviewing on top of other PRs if they aren't one feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue https://taiga.maykinmedia.nl/project/open-inwoner/task/1756 branched off from issues #1713/#1714 (= PR #773 )