Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [#1640] Add playwright tests for cookie banner #772

Merged
merged 2 commits into from
Oct 3, 2023
Merged

✅ [#1640] Add playwright tests for cookie banner #772

merged 2 commits into from
Oct 3, 2023

Conversation

stevenbal
Copy link
Contributor

No description provided.

@stevenbal stevenbal marked this pull request as draft September 19, 2023 10:56
@stevenbal stevenbal marked this pull request as ready for review September 25, 2023 07:47
Bartvaderkin
Bartvaderkin previously requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! I've added some small notes relating to the oddities of the project.

src/open_inwoner/configurations/tests/test_analytics.py Show resolved Hide resolved
src/open_inwoner/configurations/tests/test_analytics.py Outdated Show resolved Hide resolved
@stevenbal
👌 [#1640] PR feedback
119a325 
* Add ClearCachesMixin to tests to avoid data leaks
* More specific locators for cookie banner tests
@codecov-commenter
Copy link

Codecov Report

Merging #772 (119a325) into develop (1503f78) will decrease coverage by 0.53%.
Report is 43 commits behind head on develop.
The diff coverage is 24.44%.

@@             Coverage Diff             @@
##           develop     #772      +/-   ##
===========================================
- Coverage    93.56%   93.04%   -0.53%     
===========================================
  Files          697      721      +24     
  Lines        24598    25071     +473     
===========================================
+ Hits         23016    23328     +312     
- Misses        1582     1743     +161
Files Coverage Δ
...pen_inwoner/configurations/tests/test_analytics.py 71.18% <24.44%> (-28.82%) ⬇️

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit c9d4732 into develop Oct 3, 2023
14 checks passed
@alextreme alextreme deleted the feature/1640-cookiebanner-playwright-tests branch October 3, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

@Bartvaderkin Bartvaderkin Awaiting requested review from Bartvaderkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenbal @codecov-commenter @alextreme @Bartvaderkin