[#1711] [#1710] Make search filters conditional and add mobile toggle

[jiromaykin]

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1711
and also tackling issue #1710, because they are dependent: https://taiga.maykinmedia.nl/project/open-inwoner/task/1710

• Not sure if I should add all 4 options with the first one being a checkbox to turn ALL filtering OFF immediately, or if I should just show the 3 options for Categories/Tags/Organizations, so this is what I built,

EDIT: removed the first filter-option and just left the other 3.

[codecov-commenter]

Codecov Report

Merging #763 (b41bf06) into develop (1503f78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #763   +/-   ##
========================================
  Coverage    93.56%   93.57%           
========================================
  Files          697      698    +1     
  Lines        24598    24605    +7     
========================================
+ Hits         23016    23023    +7     
  Misses        1582     1582           

Files Changed	Coverage Δ
src/open_inwoner/configurations/admin.py	100.00% <ø> (ø)
src/open_inwoner/utils/context_processors.py	90.90% <ø> (ø)
...igrations/0052_siteconfiguration_search_filters.py	100.00% <100.00%> (ø)
src/open_inwoner/configurations/models.py	97.88% <100.00%> (+0.04%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Bartvaderkin]

{% spaceless %} is not a free operation and a bit of a kludge so I'm having doubts it is a good idea to slap that everywhere for cosmetics on html source nobody looks at. You can get a long way with a bit of attention to the template and how to nest raw html and template tags.

Also note in existing cases {% spaceless %} was also used in the same vein as the <p class="p"> cargo cult: it was a kludge for a particular misunderstood problem which then gets replicated everywhere, but according to spec and everything there shouldn't be a problem.

[Bartvaderkin]

Let's start removing this cargo-culted code pattern and just use forEach on the nodeList:

document.querySelectorAll(FilterMobile.selector).forEach((filterToggle) => new FilterMobile(filterToggle))

Later we'll move them to the index.

This goes for every querySelectorAll() & ;[...xxx] wart.

[jiromaykin]

@Bartvaderkin Okay, that would mean that, in future, we would need a bunch of imported Classes + initialized constants (with DOMContentLoaded event listener?) in the index file?

[Bartvaderkin]

Yes, in the future we'll add them all to the list in open_inwoner/js/components/index.js so we have a good overview of all the components, and they activate on page load as well as in htmx fragements.

[Bartvaderkin]

I'm missing tests for this but I'll have to do more work on this and possibly restructure anyway.

[Bartvaderkin]

I'll approve it and leave the filter-options.js for later when we address the components javascript.

[Bartvaderkin]

I'm merging this for an interesting rebase.