Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1709] Add info for when there are zero search results #758

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin changed the title [#1709] Add info for if there are zero search results [#1709] Add info for when there are zero search results Sep 7, 2023
@jiromaykin jiromaykin force-pushed the feature/1709-add-info-no-search-results branch from 058e089 to 1c283cb Compare September 11, 2023 09:44
@Bartvaderkin Bartvaderkin force-pushed the feature/1709-add-info-no-search-results branch from 6317218 to b8233bb Compare September 12, 2023 08:23
@Bartvaderkin
Copy link
Contributor

@jiromaykin This should be fixed now, it was more work because the search feedback tests depended on the fixed functionality and I had to figure out more about how the search works to get that cleaned up.

Also I had to rebase because of a merge conflict.

Comment on lines 53 to 55
{% spaceless %}
<div class="grid__sidebar">&nbsp;</div>
{% endspaceless %}
Copy link
Contributor

@Bartvaderkin Bartvaderkin Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this/these spaceless tags around a single tag actually do anything? I see similar on line 75 but it looks strange, like there would still be space before/after the template tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bartvaderkin Ah yes, I thought it was a styling tag, but it's not. Spaceless tag is a standard Django template tag, used because newlines/spaces in templates behave like a character. Only whitespaces between successive opening HTML tags and successive closing tags are removed, so not effective for single elements.

@jiromaykin jiromaykin marked this pull request as ready for review September 12, 2023 13:04
@jiromaykin jiromaykin force-pushed the feature/1709-add-info-no-search-results branch from c79971d to 4d40316 Compare September 12, 2023 13:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #758 (c79971d) into develop (defa012) will decrease coverage by 0.02%.
The diff coverage is 8.51%.

❗ Current head c79971d differs from pull request most recent head 4d40316. Consider uploading reports for the commit 4d40316 to get more accurate results

@@             Coverage Diff             @@
##           develop     #758      +/-   ##
===========================================
- Coverage    93.58%   93.56%   -0.02%     
===========================================
  Files          697      697              
  Lines        24595    24598       +3     
===========================================
  Hits         23016    23016              
- Misses        1579     1582       +3     
Files Changed Coverage Δ
src/open_inwoner/search/tests/test_page.py 19.73% <0.00%> (ø)
src/open_inwoner/search/tests/test_feedback.py 17.05% <7.14%> (-0.55%) ⬇️
src/open_inwoner/search/views.py 56.04% <100.00%> (+0.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit 1503f78 into develop Sep 18, 2023
14 checks passed
@alextreme alextreme deleted the feature/1709-add-info-no-search-results branch September 18, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants