-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1709] Add info for when there are zero search results #758
Conversation
058e089
to
1c283cb
Compare
6317218
to
b8233bb
Compare
@jiromaykin This should be fixed now, it was more work because the search feedback tests depended on the fixed functionality and I had to figure out more about how the search works to get that cleaned up. Also I had to rebase because of a merge conflict. |
{% spaceless %} | ||
<div class="grid__sidebar"> </div> | ||
{% endspaceless %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this/these spaceless
tags around a single tag actually do anything? I see similar on line 75 but it looks strange, like there would still be space before/after the template tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bartvaderkin Ah yes, I thought it was a styling tag, but it's not. Spaceless tag is a standard Django template tag, used because newlines/spaces in templates behave like a character. Only whitespaces between successive opening HTML tags and successive closing tags are removed, so not effective for single elements.
c79971d
to
4d40316
Compare
Codecov Report
@@ Coverage Diff @@
## develop #758 +/- ##
===========================================
- Coverage 93.58% 93.56% -0.02%
===========================================
Files 697 697
Lines 24595 24598 +3
===========================================
Hits 23016 23016
- Misses 1579 1582 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
https://taiga.maykinmedia.nl/project/open-inwoner/task/1709