Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1339] Improve translations and admin #754

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[#1339] Improve translations and admin #754

merged 2 commits into from
Sep 5, 2023

Conversation

jiromaykin
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #754 (5fb2ea5) into develop (08a3925) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #754   +/-   ##
========================================
  Coverage    96.34%   96.34%           
========================================
  Files          688      689    +1     
  Lines        24384    24388    +4     
========================================
+ Hits         23492    23496    +4     
  Misses         892      892
Files Changed Coverage Δ
src/open_inwoner/ssd/models.py 90.32% <ø> (ø)
...woner/ssd/migrations/0005_fix_translations_typo.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin marked this pull request as ready for review September 4, 2023 15:30
@alextreme
Copy link
Member

Voor de SSD admin-config sectie nog veel fuzzy. De "fuzzy" comment dien je bij een juiste vertaling weg te halen he :)

alextreme
alextreme approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dank! Ik zal er zelf donderdag nog even doorheen gaan ter voorbereiding van de release.

@alextreme alextreme merged commit 4f3341f into develop Sep 5, 2023
10 checks passed
@alextreme alextreme deleted the 1339-translations-09-04 branch September 5, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiromaykin @codecov-commenter @alextreme