Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1697] Hiding menu-button on mobile if Onderwerpen is hidden #750

Merged

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin marked this pull request as ready for review August 29, 2023 15:05
@codecov-commenter
Copy link

Codecov Report

Merging #750 (914b0e7) into develop (ae69cd9) will increase coverage by 0.02%.
Report is 33 commits behind head on develop.
The diff coverage is 99.23%.

@@             Coverage Diff             @@
##           develop     #750      +/-   ##
===========================================
+ Coverage    96.27%   96.30%   +0.02%     
===========================================
  Files          674      683       +9     
  Lines        24007    24187     +180     
===========================================
+ Hits         23113    23293     +180     
  Misses         894      894              
Files Changed Coverage Δ
...pen_inwoner/components/templatetags/header_tags.py 100.00% <ø> (ø)
src/open_inwoner/pdc/tests/test_category.py 100.00% <ø> (ø)
src/open_inwoner/ssd/tests/test_views.py 100.00% <ø> (ø)
src/open_inwoner/utils/context_processors.py 90.90% <ø> (ø)
src/open_inwoner/utils/iteration.py 92.85% <92.85%> (ø)
src/open_inwoner/haalcentraal/utils.py 94.28% <96.87%> (-0.88%) ⬇️
src/open_inwoner/accounts/signals.py 94.59% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/views/profile.py 100.00% <100.00%> (+0.58%) ⬆️
src/open_inwoner/cms/extensions/cms_menus.py 75.00% <100.00%> (+1.82%) ⬆️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin
Copy link
Contributor Author

@pi-sigma I wonder if my simple solution is correct here.

@alextreme alextreme merged commit d18beb2 into develop Aug 31, 2023
10 checks passed
@alextreme alextreme deleted the feature/1697-menubutton-on-mobile-when-onderwerpen-is-off branch August 31, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants