[#1427] Implemented OpenZaak status translation #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
commented
Aug 25, 2023
There was a problem hiding this comment.
Another one gone! 🥳
There was a problem hiding this comment.
while template_tags:
template_tags.pop()
Bartvaderkin
force-pushed
the
feature/1427-status-translation
branch
2 times, most recently
from
8d6906e
to
384b715
Compare
Bartvaderkin
commented
Aug 25, 2023
| @@ -29,7 +29,19 @@ <h1 class="h1" id="title">{{ case.description }}</h1> | |||
| {# Status history. #} | |||
| {% if case.statuses %} | |||
| <h2 class="h2" id="statuses">{% trans 'Status' %}</h2> | |||
| {% status_list case.statuses %} | |||
pi-sigma
reviewed
Aug 30, 2023
| @@ -221,6 +224,19 @@ def get_initiator_display(self, case: Zaak) -> str: | |||
| return "" | |||
| return ", ".join([get_role_name_display(r) for r in roles]) | |||
|
|
|||
| def get_statuses_data( | |||
| self, statuses: List[Status], lookup: TranslationLookup | |||
| ) -> List[dict]: | |||
There was a problem hiding this comment.
You can use the built-in type list for the annotation since we don't need to support Python < 3.9
There was a problem hiding this comment.
We should, but let's do it in one operation and sweep for all main PEP 585 containers: I created Taiga issue 1718 for it.
pi-sigma
reviewed
Aug 30, 2023
| simple key value lookup seeded from queryset.values_list(key, value) | ||
| """ | ||
|
|
||
| def __init__(self, key_value_iterable: Iterable[Tuple[str, str]]): |
There was a problem hiding this comment.
Tuple > tuple and delete import
pi-sigma
requested changes
Aug 30, 2023
Bartvaderkin
force-pushed
the
feature/1427-status-translation
branch
from
384b715
to
45b283c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #748 +/- ##
===========================================
- Coverage 96.34% 96.32% -0.02%
===========================================
Files 688 693 +5
Lines 24384 24514 +130
===========================================
+ Hits 23492 23613 +121
- Misses 892 901 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
alextreme
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This touches a lot of files, but basically just adds a simple lookup model and helper code, an admin with import/export and tests for the lookup/translate code.