Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1649] Improving spinner styling #735

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Aug 17, 2023

https://taiga.maykinmedia.nl/project/open-inwoner/task/1662

  • remove H1 titles from outer HTMX pagina's
  • add "Gegevens laden…" in outer HTMX pages
  • improve styling of spinner margins
  • Change spinner color from primary, to color-gray-dark.
  • Footer pushed below the 'fold' when spinner is visible
  • Pick different icon

@codecov-commenter
Copy link

Codecov Report

Merging #735 (b46eddc) into develop (c494770) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #735   +/-   ##
========================================
  Coverage    96.24%   96.24%           
========================================
  Files          669      669           
  Lines        23856    23856           
========================================
  Hits         22961    22961           
  Misses         895      895           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the feature/1662-customizable-spinner branch from 3c2bfd8 to dc6922c Compare August 17, 2023 14:47
@jiromaykin jiromaykin marked this pull request as ready for review August 22, 2023 08:31
@alextreme alextreme merged commit 0f356b4 into develop Aug 22, 2023
10 checks passed
@alextreme alextreme deleted the feature/1662-customizable-spinner branch August 22, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants