[#1657] add options to hide categories and search from anonymous users #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
changed the title
pi-sigma
force-pushed
the
feature/1657-optional-products-and-search
branch
from
9620d41
to
57d15fe
Compare
- added model field (bool) for hiding categories - added `LoginMaybeRequiredMixin` to categories views in order to conditionally restrict access to authenticated users - refactored rendering of nav bar (removed inclusion tags)
pi-sigma
force-pushed
the
feature/1657-optional-products-and-search
branch
from
57d15fe
to
02fed6d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #732 +/- ##
===========================================
+ Coverage 96.24% 96.27% +0.02%
===========================================
Files 669 674 +5
Lines 23860 24007 +147
===========================================
+ Hits 22965 23113 +148
+ Misses 895 894 -1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alextreme
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Looks good, however considering the refactor is a bit bigger than only the requested change @jiromaykin should also take a look (and he's back tomorrow)
I will check it out and will need to update everything locally and see what I can do here. |
jiromaykin
requested changes
Aug 17, 2023
src/open_inwoner/configurations/migrations/0048_auto_20230816_1255.py
Outdated
Show resolved
Hide resolved
pi-sigma
force-pushed
the
feature/1657-optional-products-and-search
branch
from
02fed6d
to
fce4c49
Compare
jiromaykin
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoginMaybeRequiredMixinto categories and search views in order to conditionally restrict access to authenticated usersTaiga: #1657