-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1647] Add configurable warning banner #728
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #728 +/- ##
========================================
Coverage 96.24% 96.25%
========================================
Files 668 670 +2
Lines 23855 23867 +12
========================================
+ Hits 22960 22972 +12
Misses 895 895
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/open_inwoner/components/templates/components/Header/WarningHeader.html
Show resolved
Hide resolved
6a691de
to
9712097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, @jiromaykin can give this a double-check just in case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added front-end feedback and requested changes that will be quite informative about how we use icons etc. in this project 🙂
src/open_inwoner/components/templates/components/Header/WarningHeader.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/scss/components/WarningHeader/WarningHeader.scss
Outdated
Show resolved
Hide resolved
src/open_inwoner/scss/components/WarningHeader/WarningHeader.scss
Outdated
Show resolved
Hide resolved
9712097
to
4d770e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues and it will be good to go.
src/open_inwoner/configurations/migrations/0047_auto_20230809_0833.py
Outdated
Show resolved
Hide resolved
3a3b84b
to
4e455b5
Compare
Creating test database for alias 'default'... |
e0a404d
to
a8cb305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you finally remove the unused "static/img/exclamation-encircled.svg" file then I will approve it! 😄
a8cb305
to
2976730
Compare
django.db.migrations.exceptions.NodeNotFoundError: Migration configurations.0049_siteconfiguration_extra_css dependencies reference nonexistent parent node ('configurations', '0048_auto_20230816_1255') |
2976730
to
1765857
Compare
1765857
to
8924029
Compare
Taiga: #1647