Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1647] Add configurable warning banner #728

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 9, 2023

Taiga: #1647

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #728 (9712097) into develop (4e2861a) will increase coverage by 0.00%.
Report is 10 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #728   +/-   ##
========================================
  Coverage    96.24%   96.25%           
========================================
  Files          668      670    +2     
  Lines        23855    23867   +12     
========================================
+ Hits         22960    22972   +12     
  Misses         895      895           
Files Changed Coverage Δ
src/open_inwoner/utils/context_processors.py 90.90% <ø> (ø)
src/open_inwoner/configurations/admin.py 100.00% <100.00%> (ø)
...nfigurations/migrations/0047_auto_20230809_0833.py 100.00% <100.00%> (ø)
src/open_inwoner/configurations/models.py 97.79% <100.00%> (+0.06%) ⬆️
src/open_inwoner/utils/templatetags/utils.py 91.11% <100.00%> (+0.20%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pi-sigma pi-sigma marked this pull request as ready for review August 10, 2023 08:58
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, @jiromaykin can give this a double-check just in case

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added front-end feedback and requested changes that will be quite informative about how we use icons etc. in this project 🙂

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues and it will be good to go.

src/open_inwoner/configurations/models.py Outdated Show resolved Hide resolved
src/open_inwoner/templates/master.html Show resolved Hide resolved
@pi-sigma pi-sigma force-pushed the feature/1647-banner branch 3 times, most recently from 3a3b84b to 4e455b5 Compare August 21, 2023 11:53
@alextreme
Copy link
Member

Creating test database for alias 'default'...
CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0047_auto_20230809_0833, 0048_auto_20230816_1255 in configurations).
To fix them run 'python manage.py makemigrations --merge'

@pi-sigma pi-sigma force-pushed the feature/1647-banner branch 2 times, most recently from e0a404d to a8cb305 Compare August 21, 2023 13:40
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you finally remove the unused "static/img/exclamation-encircled.svg" file then I will approve it! 😄

@alextreme
Copy link
Member

django.db.migrations.exceptions.NodeNotFoundError: Migration configurations.0049_siteconfiguration_extra_css dependencies reference nonexistent parent node ('configurations', '0048_auto_20230816_1255')

@Bartvaderkin Bartvaderkin changed the title [#1647] add configurable warning banner [#1647] Added configurable warning banner Aug 28, 2023
@pi-sigma pi-sigma changed the title [#1647] Added configurable warning banner [#1647] Add configurable warning banner Aug 29, 2023
@alextreme alextreme merged commit d0e30f3 into develop Sep 4, 2023
10 checks passed
@alextreme alextreme deleted the feature/1647-banner branch September 4, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants