[#1536] Refactored Haalcentraal to use a dataclass and update to 2.0-final

[Bartvaderkin]

The refactoring and update commits are split for convenience.

[alextreme]

Ziet er in principe netjes uit. Je houdt volgens mij hiermee nog wel rekening ermee dat Groningen nog HC BRP v1.3 hanteert, toch?

[Bartvaderkin]

@alextreme Ja die switch op settings.BRP_VERSION zit er nog in.

[pi-sigma]

• I don't think there is a setting LOG_OUTGOING_REQUESTS_ENABLED
• LOG_OUTGOING_REQUESTS_DB_SAVE=True is the default, so override shouldn't be necessary

[Bartvaderkin]

Good catch, I see this got updated since I last had overrides in my local.py

I'm keeping the @override_settings(LOG_OUTGOING_REQUESTS_DB_SAVE=True) here because settings like these are often modified in local.py (as I do).

[pi-sigma]

Oddly the line I want to comment doesn't show up in this view (only if you follow "show file").

Instead of

 if data.get("personen"):
     data = data.get("personen", [])[0]
 else:
     data = []

perhaps the following:

if data := data.get("personen", []):
    data = data[0]

then you can ditch the else clause.

[Bartvaderkin]

Ugh, some old code I should have addressed.

I updated the code, with a small change of not using the default value for .get(), because we want the None value for the walrus operator.

if data := data.get("personen"):
    data = data[0]

[pi-sigma]

Couple of small remarks/suggestions.

[Bartvaderkin]

Thanks for the feedback, I updated the PR with new commits.