Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1655] Fix SSD #726

Merged
merged 4 commits into from
Aug 9, 2023
Merged

[#1655] Fix SSD #726

merged 4 commits into from
Aug 9, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 8, 2023 •
edited
Loading

  • make Jaaropgave report fit on a single PDF page (Taiga #1655)
  • translate month names (Taiga #1652)
  • add SSDConfig and SOAP Services to admin-index-fixture (Taiga #1653)
  • fix maandspecificatie endpoint (Taiga #1654)

@pi-sigma pi-sigma marked this pull request as ready for review August 9, 2023 09:51
@pi-sigma pi-sigma requested a review from alextreme August 9, 2023 09:54
@alextreme
Copy link
Member

Looks good. And @Bartvaderkin was indeed correct, field-length changes didn't trigger a migration so it's validated by Django instead of Postgresql.

@alextreme alextreme merged commit 141896e into develop Aug 9, 2023
@alextreme alextreme deleted the fix/1655-jaaropgave-pdf branch August 9, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi-sigma @alextreme