-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿ [#1604] Making thumbs-up inputs tabbable #709
♿ [#1604] Making thumbs-up inputs tabbable #709
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #709 +/- ##
========================================
Coverage 96.20% 96.20%
========================================
Files 642 642
Lines 22934 22934
========================================
Hits 22064 22064
Misses 870 870 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7d54509
to
e05b2a2
Compare
@pi-sigma this one might be a bit annoying to review since most of the code is for accessibility only (like: what will be read out loud by screenreaders by "
Accessibility references: |
3714e34
to
4360ebd
Compare
887c08d
to
4399ba9
Compare
@pi-sigma this one took longer than expected - but it's finished now (this is the PR I retracted and put back in Draft few weeks ago but now it can be reviewed by you) |
…elijk-search-page
https://taiga.maykinmedia.nl/project/open-inwoner/task/1604
to review:
NOTE: IN ORDER TO REACH the thumbs-up or thumbs-down buttons on 'tab' in the Search query page (http://127.0.0.1:8000/search/?query=gemeente ), you need to use the ARROW KEYS in order to navigate between them (= standard behaviour for radio buttons and/or check-boxes)
this PR corrects a number of accessibility errors from Lighthouse (devtools) and corrects some of the
aria-labels
androles
+ it corrects HTML syntax: it is actually quite forbidden to put Labels inside other Labels (there's more in the entire project, but that will be solved in a different issue) + it corrects some accessibility contrast errors as well. So for documentupload widget: since all of the styling in the project for the Labels was done with a generic HTML 'Label' tag selector, all CSS styling for the DocumentUpload will have to target both the parent 'label
' as well as the child 'label__label
' - that's why it looks like the CSS is 'double'Elements that are mainly affected by this PR are:
Done in this PR:
The aria-label overrides anything inside the Label and other tags inside (so those will often not be read by screen-readers).