-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1548] Refactor profile deletion flow #683
Conversation
3466240
to
09ba067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please update the name of the form as well (
deactivate-form
) in order to be more clear what we are doing here. - Update the User's
deactivated_on
field - clear enough that this is deprecated - Do a search for "deactivate", there are a couple of spots that could be updated as well
Codecov Report
@@ Coverage Diff @@
## develop #683 +/- ##
===========================================
- Coverage 96.17% 96.16% -0.01%
===========================================
Files 633 635 +2
Lines 22665 22641 -24
===========================================
- Hits 21797 21772 -25
- Misses 868 869 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c10aa7d
to
f3f3339
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small remarks and this can be merged.
Please update the form name ("deactivate-form" is not representative) and in my opinion the help-text of the User's model field (deactivated_on
) should mention that this is deprecated since the account is now deleted.
f3f3339
to
06e1dbe
Compare
06e1dbe
to
63d23fa
Compare
@vaszig can this be approved now? Would like to get this into the v1.8 release |
Yes, sure. I thought it was not ready yet. |
Appreciated, thanks guys! |
Taiga: #1548
Refactor profile deletion flow: