✨ [#1537] Adding cookie-consent banner

[jiromaykin]

Cookie-banner that respects the GDPR privacy laws, and gives the user the chance to dismiss the non-essential cookies only.
https://taiga.maykinmedia.nl/project/open-inwoner/task/1537

IF the Admin does NOT want to use the cookiebanner, THEN analytics cookies need to be set to true.
IF Admin wants to use the banner, THEN analytics need to be set to false when cookies are rejected by the local user, and to true when approved. + Analytics must be on by default, unless there is a cookiebanner set.

• style modal pop-up to be open onLoad
• make cookiebanner optional in config (not visible)
• add default Admin configuration texts (Scroll down to Cookie consent in http://127.0.0.1:8000/admin/configurations/siteconfiguration/)
• reject all or accept all approve/dismiss
• remember user choice across context/all pages for 90days(?) - this means the cookiebanner won't show for 90 days when it is clicked, but it will come back again due to the expirationTime in JS
• make reject script actually reject ALL from Google/Matomo/Siteimprove
• make the cookiebanner work for failing tests (error "intercepts pointer events... retrying click action" => ERROR: test_action_status (failing tests: 1. file: open_inwoner/accounts/tests/test_action_views.py, 2. test: open_inwoner/accounts/tests/test_action_views.py 'test_action_status' 3. file: open_inwoner/cms/cases/tests/test_htmx.py 4. htmx: test_cases, 5. file open_inwoner/plans/tests/test_views.py, 6. test "test_action_status")
• add migrations

Challenge: (not in this issue) not making the cookie-banner appear on the Privacy policy page? Right now you first have to click it it in order to be able to read it; (if the cookie-banner is shown, it has to block all other interactions).

[codecov-commenter]

Codecov Report

Merging #681 (34607a6) into develop (5ea47fc) will decrease coverage by 0.04%.
The diff coverage is 67.74%.

@@             Coverage Diff             @@
##           develop     #681      +/-   ##
===========================================
- Coverage    96.20%   96.16%   -0.04%     
===========================================
  Files          642      643       +1     
  Lines        22934    22959      +25     
===========================================
+ Hits         22064    22079      +15     
- Misses         870      880      +10     

Impacted Files	Coverage Δ
...c/open_inwoner/accounts/tests/test_action_views.py	86.84% <0.00%> (-1.95%)	⬇️
src/open_inwoner/cms/cases/tests/test_htmx.py	55.72% <0.00%> (-2.22%)	⬇️
src/open_inwoner/configurations/admin.py	100.00% <ø> (ø)
src/open_inwoner/utils/context_processors.py	90.90% <ø> (ø)
...igrations/0046_siteconfiguration_cookie_consent.py	100.00% <100.00%> (ø)
src/open_inwoner/configurations/models.py	97.72% <100.00%> (+0.10%)	⬆️
...pen_inwoner/configurations/tests/test_analytics.py	100.00% <100.00%> (ø)
src/open_inwoner/utils/templatetags/utils.py	90.90% <100.00%> (+0.90%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jiromaykin]

@Bartvaderkin and @pi-sigma I don't know too much about writing tests yet (so a review of what I did in accounts/tests/test_action_views.py and in cms/cases/tests/test_htmx.py is much appreciated) + and I am not sure if my way of adding context-processors (in order to configure the banner from the admin) is the correct way to do it.... so feel free to leave feedback. for improvement.

[pi-sigma]

1. The test is for the action view, which has nothing specifically to do with cookies. This would need to be a separate test.
2. If we're going to test the hiding of the cookie banner, we should also test that it's hidden when the 'accept' button is clicked.

However, I'm not sure this is even needed. We can confirm manually that the banner is hidden on click. What we do need to check automatically is that the analytics scripts are not rendered when the cookie is not set. You should modify the test in src/open_inwoner/configurations/tests/test_analytics.py (I should have done this myself when I changed the test, but didn't think of it back then).

[jiromaykin]

@pi-sigma I didn't know what to do here, because this test was failing when I added the cookiebanner, because the cookiebanner is blocking all other clicks when it pops up so I add something-that-clicks-something but I definitely don't know what I am doing here (I would prefer to set " self.cookiebanner_enabled" to False but that didn't work.)

[pi-sigma]

See previous comment

[alextreme]

Discussed with Jiro and Paul:

• test needs to be added to check that the analytics aren't used if the cookies aren't accepted
• test_action_views needs to be modified, expect-changes about the cookiebanner should be removed (it should work without or be mocked)

[jiromaykin]

@pi-sigma I've added the new tests here. Question: I am assuming that if cookie_info_text is set to a string with content here, instead of empty, the tests below should actually be failing since analytics should then be off by default?
All other behaviour behaves conforming to the assertions.

[alextreme]

3 failing tests:

2023-08-01T09:02:21.1027134Z ERROR: test_action_status (open_inwoner.accounts.tests.test_action_views.ActionsPlaywrightTests)
2023-08-01T09:02:21.1236333Z ERROR: test_cases (open_inwoner.cms.cases.tests.test_htmx.CasesPlaywrightTests)
2023-08-01T09:02:21.1397757Z ERROR: test_action_status (open_inwoner.plans.tests.test_views.PlanActionStatusPlaywrightTests)

[jiromaykin]

Nice! @pi-sigma I had no idea... now this is ready for review again.