Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1455] Add contact form to case detail page #671

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jun 13, 2023

No description provided.

@vaszig vaszig marked this pull request as draft June 13, 2023 14:32
@vaszig vaszig changed the title [#1455] Added contact form to case detail page [#1455] Add contact form to case detail page Jun 13, 2023
Base automatically changed from feature/1439-add-htmx-to-cases to develop June 14, 2023 10:14
@vaszig vaszig force-pushed the feature/1455-add-contactform-to-case-detail branch 5 times, most recently from 24f9127 to 67aaf32 Compare June 20, 2023 11:20
@vaszig vaszig force-pushed the feature/1455-add-contactform-to-case-detail branch from 67aaf32 to bf898b8 Compare June 20, 2023 14:04
@vaszig vaszig marked this pull request as ready for review June 20, 2023 14:58
@alextreme
Copy link
Member

Merging this in without review yet. @Bartvaderkin please double-check this tomorrow, but this gives Vasileios the option to double-check on the testenvironment.

If there are blocking requests I'll revert the commit and skip this part in the demo, if there are requests for improvement please create a separate task for these so Vasileios can clean them up.

@alextreme alextreme merged commit 1282e20 into develop Jun 21, 2023
@alextreme alextreme deleted the feature/1455-add-contactform-to-case-detail branch June 21, 2023 13:59
@jiromaykin
Copy link
Contributor

@alextreme I did not have the chance to review this on my part-time day off :-) but I'd like to review it when needed.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaszig I added reviews notes, but it'll obviously have to be a new PR.

src/open_inwoner/cms/cases/tests/test_htmx.py Show resolved Hide resolved
src/open_inwoner/cms/cases/views/status.py Show resolved Hide resolved
src/open_inwoner/cms/cases/views/status.py Show resolved Hide resolved
src/open_inwoner/cms/cases/views/status.py Show resolved Hide resolved
src/open_inwoner/cms/cases/views/status.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants