Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1519] remove files from profile sidebar if files are empty #658

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jun 7, 2023

Related: #622

Taiga: #1519

@pi-sigma pi-sigma requested a review from jiromaykin June 7, 2023 12:54
@codecov-commenter
Copy link

Codecov Report

Merging #658 (aeed4ea) into develop (08d9a69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #658   +/-   ##
========================================
  Coverage    96.45%   96.45%           
========================================
  Files          618      618           
  Lines        21857    21860    +3     
========================================
+ Hits         21083    21086    +3     
  Misses         774      774           
Impacted Files Coverage Δ
src/open_inwoner/accounts/views/profile.py 99.31% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and behaves good - Note: we hardly use the 'issues' branch - usually something is a 'fix' or part of our 'feature' branche.

@alextreme alextreme merged commit 3633df0 into develop Jun 8, 2023
@alextreme alextreme deleted the issue/1519-sidebar-files branch June 8, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants