[#1482] Added 'infix' (tussenvoegsel) to User model #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
force-pushed
the
feature/1456-user-infix
branch
3 times, most recently
from
99895a3
to
025c12c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #633 +/- ##
===========================================
- Coverage 96.51% 96.50% -0.02%
===========================================
Files 600 605 +5
Lines 20684 20792 +108
===========================================
+ Hits 19964 20066 +102
- Misses 720 726 +6
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vaszig
requested changes
May 25, 2023
| @@ -31,15 +30,16 @@ def test_signal_updates_users_data_when_logged_in_via_digid_v_2(self, m): | |||
| user.bsn = "999993847" | |||
| user.save() | |||
|
|
|||
| updated_user = User.objects.filter(email=user.email) | |||
| user.refresh_from_db() | |||
There was a problem hiding this comment.
Thanks for the updated part!
Thanks, weird how I missed that. I appended a commit for it. |
vaszig
approved these changes
May 26, 2023
Bartvaderkin
force-pushed
the
feature/1456-user-infix
branch
from
3b433c3
to
5c864b2
Compare
Bartvaderkin
changed the title
|
Sorry, but I had to force-push this again because I had the wrong ticket number in the commit log 😞 (I'll leave the branch name because it is not that important after it is merged) |
alextreme
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.