Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1467] Fix logo stretching in Safari and position of Search #628

Merged

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented May 22, 2023

Note: the logo stretching problem can only be reviewed in Safari (Browserstack).
PNG and other images stretch on both desktop and mobile (SVG's remain the same)-> this PR should solve that problem.
everything else can be reviewed in all browsers.

  • set logo to static height for mobile and desktop
  • decrease header margin bottom, make logo smaller in header
  • improve search bar margins for mobile in all browsers
  • increase space in mobile menu between icons and page-titles

(NB: on very tiny screens the logo will become smaller when the mobile menu is opened because the scrollbar appears, taking up horizontal space).

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #628 (a2ec139) into develop (d1e4c71) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #628   +/-   ##
========================================
  Coverage    96.51%   96.51%           
========================================
  Files          600      600           
  Lines        20684    20684           
========================================
  Hits         19964    19964           
  Misses         720      720           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the fix/1467-mobile-safari-logo-stretching-and-search-position branch from f1762b1 to dec23d2 Compare May 23, 2023 09:17
@jiromaykin jiromaykin marked this pull request as ready for review May 23, 2023 10:32
@alextreme alextreme merged commit 6491b8e into develop May 25, 2023
@alextreme alextreme deleted the fix/1467-mobile-safari-logo-stretching-and-search-position branch May 25, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants