Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1438] Add static placeholder for login banner #614

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 11, 2023

No description provided.

@vaszig vaszig marked this pull request as draft May 11, 2023 12:36
@vaszig vaszig marked this pull request as ready for review May 11, 2023 13:15
@vaszig vaszig marked this pull request as draft May 11, 2023 13:18
@vaszig vaszig force-pushed the feature/1438-add-banner-static-placeholder-to-login-page branch from cdb1d62 to 52c6431 Compare May 24, 2023 08:32
@vaszig vaszig marked this pull request as ready for review May 24, 2023 08:32
@codecov-commenter
Copy link

Codecov Report

Merging #614 (52c6431) into develop (f695ae1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #614   +/-   ##
========================================
  Coverage    96.52%   96.52%           
========================================
  Files          604      604           
  Lines        20754    20754           
========================================
  Hits         20032    20032           
  Misses         722      722           
Impacted Files Coverage Δ
src/open_inwoner/conf/base.py 95.40% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig requested a review from Bartvaderkin May 24, 2023 09:31
@Bartvaderkin
Copy link
Contributor

@vaszig Did you get this working as expected? I recall earlier I had to look at it but didn't have the time, and now you marked it.

@vaszig vaszig removed the request for review from Bartvaderkin May 26, 2023 09:08
@vaszig
Copy link
Contributor Author

vaszig commented May 26, 2023

@vaszig Did you get this working as expected? I recall earlier I had to look at it but didn't have the time, and now you marked it.

This is working as expected, it was tested locally and the user (logged in admin) can modify the banner (the height as well) via http://localhost:8000/accounts/login/?edit.

@vaszig vaszig requested a review from Bartvaderkin May 26, 2023 11:39
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@alextreme alextreme merged commit 3f4f234 into develop May 30, 2023
@alextreme alextreme deleted the feature/1438-add-banner-static-placeholder-to-login-page branch May 30, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants