-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1378] Updated new menus to use dynamic pages #613
Conversation
48cc47c
to
e0eb60d
Compare
c80f731
to
9ddb4d1
Compare
e0eb60d
to
8c4e177
Compare
9ddb4d1
to
6f4e15d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alextreme and @Bartvaderkin I rebased my own branch from PR591, which maybe resulted in conflicts in this branch? |
Codecov Report
@@ Coverage Diff @@
## develop #613 +/- ##
===========================================
- Coverage 96.52% 96.40% -0.12%
===========================================
Files 577 579 +2
Lines 19891 19942 +51
===========================================
+ Hits 19199 19226 +27
- Misses 692 716 +24
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use some caching to avoid determining the active apphooks on every request, but considering it's a single query this should be okay for now
This assumes you have the authenticated pages as children of the homepage in the tree, and use 'home' as ID in the page's advanced settings.
The products/onderwerpen are still rendered as they were, until we move the content to actual pages.
Note I also added a context manager that adds some data to check if an app is active.
Relates to #591