[#1405] Cleanup 'show_xyz' booleans from siteconfiguration #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
changed the base branch from
develop
to
feature/1397-django-cms-profile-apphookconfig
vaszig
force-pushed
the
feature/1405-cleanup-booleans-from-siteconfiguration
branch
from
901b3b1
to
a747a4b
Compare
Codecov Report
@@ Coverage Diff @@
## feature/1397-django-cms-profile-apphookconfig #609 +/- ##
=================================================================================
+ Coverage 95.97% 96.40% +0.43%
=================================================================================
Files 575 573 -2
Lines 19950 19793 -157
=================================================================================
- Hits 19147 19082 -65
+ Misses 803 711 -92
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vaszig
force-pushed
the
feature/1405-cleanup-booleans-from-siteconfiguration
branch
2 times, most recently
from
5838024
to
69742fb
Compare
|
Did a quick check with Vasileios and looks good imho |
Bartvaderkin
suggested changes
May 11, 2023
Base automatically changed from
feature/1397-django-cms-profile-apphookconfig
to
develop
May 11, 2023 09:13
vaszig
force-pushed
the
feature/1405-cleanup-booleans-from-siteconfiguration
branch
from
aa6cb86
to
fd9a6fd
Compare
Bartvaderkin
approved these changes
May 11, 2023
Bartvaderkin
deleted the
feature/1405-cleanup-booleans-from-siteconfiguration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #597