Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1312] Make banner height adjustable #605

Merged
merged 1 commit into from
May 4, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 3, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #605 (d331c48) into develop (fb5aa32) will decrease coverage by 0.03%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
- Coverage    96.03%   96.01%   -0.03%     
===========================================
  Files          568      570       +2     
  Lines        19855    19874      +19     
===========================================
+ Hits         19068    19082      +14     
- Misses         787      792       +5     
Impacted Files Coverage Δ
src/open_inwoner/cms/banner/forms.py 58.33% <58.33%> (ø)
src/open_inwoner/cms/banner/cms_plugins.py 100.00% <100.00%> (ø)
.../cms/banner/migrations/0002_banner_image_height.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/banner/models.py 90.00% <100.00%> (+1.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin
Copy link
Contributor

@vaszig This doesn't have the option to select a preview or 'location aware cropping' - is that something we will add later?

@vaszig
Copy link
Contributor Author

vaszig commented May 4, 2023

@vaszig This doesn't have the option to select a preview or 'location aware cropping' - is that something we will add later?

Discussed with @alextreme and decided to go for a simple height adjustment (via the form upload) which will be done only for the frontend.

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice! (although we need to add to the manual the banner will not be visible until the user is logged out, so the admin won't see it either when logged in).

@alextreme alextreme merged commit a76482f into develop May 4, 2023
@alextreme alextreme deleted the feature/1312-make-banner-height-adjustable branch May 4, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants