-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [#1378] Header multiple navigation (mobile and desktop) #591
🎨 [#1378] Header multiple navigation (mobile and desktop) #591
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #591 +/- ##
===========================================
+ Coverage 96.39% 96.50% +0.10%
===========================================
Files 574 573 -1
Lines 19811 19773 -38
===========================================
- Hits 19096 19081 -15
+ Misses 715 692 -23
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dc92b3e
to
2962687
Compare
893012d
to
4a9c982
Compare
@vaszig : these are the 3 new menus, all static for the moment. |
e269180
to
ac46aee
Compare
@Bartvaderkin this is the big one... up for review. |
@jiromaykin the PR got outdated and has a merge conflict, can you rebase on develop and push again? |
@ bart Okay I will. |
c80f731
to
9ddb4d1
Compare
9ddb4d1
to
6f4e15d
Compare
new mobile header designs + 2 new desktop menus:
https://projects.invisionapp.com/share/B3137YU0PZY2#/screens?browse
In order to view the styles correctly for review: turn off the Django CMS-toolbar
(http://127.0.0.1:8000/?toolbar_off)
adds feature to issue mobile: https://taiga.maykinmedia.nl/project/open-inwoner/task/1378
also adds feature to issue for desktop header: https://taiga.maykinmedia.nl/project/open-inwoner/task/1377
and adds feature to issue for indicator + dot: https://taiga.maykinmedia.nl/project/open-inwoner/task/1398
📲 Mobile menu:
Mobile menu works in all browsers the same
🖥️ Desktop menu:
🔔 Note:
NB: in Firefox desktop the Tab can't reach the submenu-items unless accessibility.tabfocus is set to number=7 in the about:config settings - which may be an issue on Mac only: https://support.mozilla.org/en-US/questions/1278793
NB: In Safari Tab won't work if user forgets to turn on accessibility (Settings > Advanced > Turn on Tab...).