[#1326] Fix phonenumber, email and url in product location cards #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
requested changes
Apr 6, 2023
Bartvaderkin
approved these changes
Apr 6, 2023
|
@jiromaykin I hope I did this in the right way! I added this rule for the product location cards as well.
|
jiromaykin
requested changes
Apr 6, 2023
| .link + .link { | ||
| .link | ||
| + .link | ||
| :not(.card__body--flex > a > span, .leaflet-content-details > a > span) { |
There was a problem hiding this comment.
it seems like the linter broke off the ":not" selector so it doesn't work anymore; also this ":not" selector is a bit dangerous to use if it's just 1 or 2 exceptions; so better to correct the original style, which was faulty and not specific enough, because it dealt with the wrong exception (not your blame :-D ).
The style for the numbers in the main Navigation here should onl be:
.primary-navigation { &__list-item .link.link--secondary { margin-left: var(--spacing-small); } }
declared outside of the ".link" curly braces.
This way all the other links everywhere will not be affected.
jiromaykin
approved these changes
Apr 11, 2023
alextreme
deleted the
fix/1326-phonenumber-and-email-in-product-detail-dont-work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://taiga.maykinmedia.nl/project/open-inwoner/issue/1252 as well.