-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1306-7] Update case and case type texts in case list and status views #569
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #569 +/- ##
========================================
Coverage 96.72% 96.72%
========================================
Files 546 547 +1
Lines 19399 19404 +5
========================================
+ Hits 18764 18769 +5
Misses 635 635
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
else self.case.zaaktype.omschrijving | ||
), | ||
"type_description": ( | ||
self.case.zaaktype.omschrijving if self.case.omschrijving else "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note the condition in type_description
looks at a different attribute then the left side but suppose it is intentional and related to the regular description
just above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was done on purpose in order to have case type description only once in the page. After discussing this with Alex I removed it because this field does not exist in the design.
@vaszig Oops, I just noticed you re-draft-ed this earlier but I had the window still open from before and accidentally reviewed. |
@Bartvaderkin ready for review now |
I have also removed the case type description from the status page as it is not in the design.