Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1306-7] Update case and case type texts in case list and status views #569

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 4, 2023

I have also removed the case type description from the status page as it is not in the design.

@codecov-commenter
Copy link

Codecov Report

Merging #569 (049a8c8) into develop (f2e590f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    96.72%   96.72%           
========================================
  Files          546      547    +1     
  Lines        19399    19404    +5     
========================================
+ Hits         18764    18769    +5     
  Misses         635      635           
Impacted Files Coverage Δ
src/open_inwoner/accounts/views/cases.py 98.10% <ø> (ø)
src/open_inwoner/openzaak/tests/test_cases.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig requested review from Bartvaderkin and alextreme and removed request for Bartvaderkin and alextreme April 4, 2023 11:42
@vaszig vaszig marked this pull request as draft April 4, 2023 13:29
else self.case.zaaktype.omschrijving
),
"type_description": (
self.case.zaaktype.omschrijving if self.case.omschrijving else ""
Copy link
Contributor

@Bartvaderkin Bartvaderkin Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note the condition in type_description looks at a different attribute then the left side but suppose it is intentional and related to the regular description just above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was done on purpose in order to have case type description only once in the page. After discussing this with Alex I removed it because this field does not exist in the design.

@Bartvaderkin
Copy link
Contributor

@vaszig Oops, I just noticed you re-draft-ed this earlier but I had the window still open from before and accidentally reviewed.

@vaszig vaszig marked this pull request as ready for review April 4, 2023 13:58
@alextreme
Copy link
Member

@Bartvaderkin ready for review now

@alextreme alextreme merged commit 243cc5d into develop Apr 6, 2023
@alextreme alextreme deleted the task/1306-change-case-texts branch April 6, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants