Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified error handling codestyle in ZGW fetch-functions #562

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review March 30, 2023 11:59
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should fix this in open_inwoner/haalcentraal/utils.py as well, since you did it nicer now!Or not?Because I see we use it in cases, catalog, documents and formapi as well.

@Bartvaderkin
Copy link
Contributor Author

Good idea, I appended a commit for this.

@codecov-commenter
Copy link

Codecov Report

Merging #562 (7ef810e) into develop (6806072) will increase coverage by 0.23%.
The diff coverage is 56.00%.

@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
+ Coverage    96.49%   96.73%   +0.23%     
===========================================
  Files          546      546              
  Lines        19467    19395      -72     
===========================================
- Hits         18785    18761      -24     
+ Misses         682      634      -48     
Impacted Files Coverage Δ
src/open_inwoner/openzaak/formapi.py 83.87% <0.00%> (+7.40%) ⬆️
src/open_inwoner/openzaak/catalog.py 64.28% <37.50%> (+9.87%) ⬆️
src/open_inwoner/haalcentraal/utils.py 95.08% <50.00%> (+4.03%) ⬆️
src/open_inwoner/openzaak/cases.py 86.70% <63.63%> (+8.17%) ⬆️
src/open_inwoner/openzaak/documents.py 94.11% <100.00%> (-0.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit 0b06110 into develop Apr 2, 2023
@alextreme alextreme deleted the fix/simpler-fetchers branch April 2, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants