Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1257] Underline anchors in some content #561

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Mar 28, 2023

issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/1257

  • add underline for links in productpage content
  • add underline for links in FAQ content + black when closed, blue when open + fix incorrect arrow direction.
  • check with designer whether links should be strong

After consultation with designer: all links inside content should be underlined, also if they are inside location-cards and faq's; they do not need to be bold.

NB: the strange spacing before links is corrected in a different PR that deals with the weird link-spacing in leaflet /maps.

Screenshot 2023-04-11 at 14 05 36

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #561 (2025d6a) into develop (6806072) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
+ Coverage    96.49%   96.73%   +0.23%     
===========================================
  Files          546      547       +1     
  Lines        19467    19425      -42     
===========================================
+ Hits         18785    18790       +5     
+ Misses         682      635      -47     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin marked this pull request as ready for review April 11, 2023 09:59
@jiromaykin jiromaykin requested a review from vaszig April 11, 2023 10:10
@jiromaykin jiromaykin requested a review from vaszig April 11, 2023 13:02
@alextreme alextreme merged commit 8354bd0 into develop Apr 12, 2023
@alextreme alextreme deleted the feature/1257-underline-anchors-in-content branch April 12, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants