[#1249] Add headers to outgoing requests logging #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
commented
Mar 16, 2023
| @@ -30,7 +31,7 @@ def install_outgoing_requests_logging(): | |||
| Session._original_request = Session.request | |||
|
|
|||
| def new_request(self, *args, **kwargs): | |||
| kwargs.setdefault("hooks", {"response": hook_requests_logging}) | |||
| self.hooks["response"].append(hook_requests_logging) | |||
There was a problem hiding this comment.
This was changed in case we add more hooks to the session
Codecov Report
@@ Coverage Diff @@
## develop #539 +/- ##
========================================
Coverage 96.47% 96.48%
========================================
Files 540 541 +1
Lines 19216 19243 +27
========================================
+ Hits 18539 18566 +27
Misses 677 677
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
suggested changes
Mar 20, 2023
vaszig
force-pushed
the
fix/1249-add-headers-to-outgoing-requests-logging
branch
from
a702f21
to
179464a
Compare
Bartvaderkin
suggested changes
Mar 21, 2023
Bartvaderkin
suggested changes
Mar 23, 2023
Bartvaderkin
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.