Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [#1132] Add select-caret and filters for contacts #520

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jiromaykin
Copy link
Contributor

select tag needs arrow/caret
https://taiga.maykinmedia.nl/project/open-inwoner/issue/1132

After discussing with Roxanne (designer):

  • translation/textually "soort contact" and "type contact" should be the same; so pick one and use consistently (TODO later in translations), either use "soort contact" everywhere, or use "type contact" everywhere.
  • align the Select element to the right
  • add icon with expand_more arrow/caret
  • discuss with designer if all filter-pages should look consistent
  • delete the old PR/branch due to mess with merge-conficts, translations and wrong name.
  • refactor Filters section to look more like all the others (like in Plans and Actions)
  • Today I just found out that these filters should only be visible in the ‘Begeleider’ view, but for now I'll just make it look like all the other filter-views that we have. + Adding a Search field would be a task for later future.

@jiromaykin jiromaykin marked this pull request as ready for review March 7, 2023 15:06
@jiromaykin
Copy link
Contributor Author

jiromaykin commented Mar 7, 2023

Because I'm surrounding the Contacts section with a Div, I had to indent the code inside; hence why it looks like there is a lot of 'new' code.

@vaszig and @Bartvaderkin : this is a new, clean branch of the issue that was approved last week, but without the crazy merge-conflicts and translation errors, so feel free to review this one again.

.contacts {
font-family: var(--font-family-body);

.contacts__filter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mainly use &__filter format and not again the whole name (like you do with &--open modifier) in the project, just mentioning for future updates. Same below.


toggleOpen(event) {
event.preventDefault()
this.node.parentElement.parentElement.classList.toggle(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: selecting up with a .parent.parent type of lookup is generally not a great pattern. It's better to select the outside first and then grab sub-parts, or use a real selector.

@alextreme alextreme merged commit c124b26 into develop Mar 13, 2023
@alextreme alextreme deleted the feature/1132-add-select-caret-for-contacts-page branch March 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants