Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [#1168] Make Theme cards entirely clickable #519

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jiromaykin
Copy link
Contributor

See issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1168
Theme/Category- cards need to be entirely clickable, unless they show Subthemes/Products.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #519 (f8a1647) into develop (4b09a8c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #519      +/-   ##
===========================================
+ Coverage    96.48%   96.52%   +0.03%     
===========================================
  Files          527      527              
  Lines        19003    19023      +20     
===========================================
+ Hits         18335    18361      +26     
+ Misses         668      662       -6     
Impacted Files Coverage Δ
src/open_inwoner/utils/ckeditor.py 75.00% <0.00%> (-17.31%) ⬇️
src/open_inwoner/pdc/models/category.py 89.18% <0.00%> (-8.11%) ⬇️
...rc/open_inwoner/pdc/tests/test_product_location.py 100.00% <0.00%> (ø)
.../open_inwoner/components/templatetags/link_tags.py 100.00% <0.00%> (ø)
src/open_inwoner/pdc/models/product.py 89.70% <0.00%> (+0.31%) ⬆️
src/open_inwoner/pdc/views.py 88.10% <0.00%> (+0.37%) ⬆️
src/open_inwoner/utils/templatetags/utils.py 90.00% <0.00%> (+27.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin
Copy link
Contributor Author

jiromaykin commented Mar 6, 2023

The biggest challenge here was the fact that it is impossible to have a-hrefs inside a-hrefs in HTML, so these are the same card but with an if/else state to see if thay contain Subthemes/Products or not - in future i will need to simplify these, but this is for the Theme cards only for now:

Screenshot from 2023-03-06 16-34-47

@jiromaykin jiromaykin marked this pull request as ready for review March 7, 2023 09:10
@alextreme alextreme merged commit 2770e3b into develop Mar 8, 2023
@alextreme alextreme deleted the feature/1168-make-entire-Theme-card-clickable branch March 8, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants