Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1158] Add image field for begeleider user #499

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 24, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #499 (d0ac9cf) into develop (da251bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #499   +/-   ##
========================================
  Coverage    96.50%   96.51%           
========================================
  Files          514      515    +1     
  Lines        18561    18612   +51     
========================================
+ Hits         17913    17964   +51     
  Misses         648      648           
Impacted Files Coverage Δ
src/open_inwoner/accounts/admin.py 93.97% <100.00%> (+0.38%) ⬆️
...pen_inwoner/accounts/migrations/0054_user_photo.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/models.py 97.84% <100.00%> (+0.01%) ⬆️
src/open_inwoner/accounts/tests/test_admin.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to name the field 'photo'? It feels odd, usually it is a 'profile picture' or 'image'?

src/open_inwoner/accounts/models.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/models.py Outdated Show resolved Hide resolved
@vaszig vaszig requested a review from Bartvaderkin March 1, 2023 09:24
@alextreme alextreme merged commit e47d914 into develop Mar 1, 2023
@alextreme alextreme deleted the feature/1158-add-imagefield-to-user branch March 1, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants