Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1161] Added 'description' to Plan model, 'goal' and 'description' to Plan forms & views #497

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Feb 23, 2023

Note this is based on PR #494 because it touches the same views, migrations etc.

For review I set the merge target to that same branch; iirc Github will update it once that lands.

@Bartvaderkin Bartvaderkin force-pushed the feature/1161-add-goal-description-to-plans branch from 6808825 to 0953e69 Compare February 23, 2023 14:56
@codecov-commenter
Copy link

Codecov Report

Merging #497 (0953e69) into feature/1162-remove-goal-from-actions (ff4e8aa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                            Coverage Diff                            @@
##           feature/1162-remove-goal-from-actions     #497      +/-   ##
=========================================================================
- Coverage                                  96.52%   96.51%   -0.01%     
=========================================================================
  Files                                        516      517       +1     
  Lines                                      18719    18587     -132     
=========================================================================
- Hits                                       18069    17940     -129     
+ Misses                                       650      647       -3     
Impacted Files Coverage Δ
src/open_inwoner/plans/forms.py 100.00% <100.00%> (ø)
...nwoner/plans/migrations/0013_auto_20230223_1115.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/models.py 98.52% <100.00%> (+0.04%) ⬆️
src/open_inwoner/plans/tests/factories.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/tests/test_logging.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/tests/test_views.py 100.00% <100.00%> (ø)
...c/open_inwoner/utils/tests/test_timeline_logger.py 100.00% <100.00%> (ø)
.../open_inwoner/components/templatetags/form_tags.py 94.30% <0.00%> (-0.82%) ⬇️
src/open_inwoner/plans/views.py 97.83% <0.00%> (-0.30%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review February 23, 2023 15:58
Base automatically changed from feature/1162-remove-goal-from-actions to develop February 27, 2023 13:13
@alextreme alextreme merged commit 0162e4b into develop Feb 27, 2023
@alextreme alextreme deleted the feature/1161-add-goal-description-to-plans branch February 27, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants