Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#860] Issue/limit max length of product summary #482

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 20, 2023

No description provided.

@vaszig vaszig force-pushed the issue/860-reduce-product-summary-max-length branch from e4c8837 to f22d99d Compare February 21, 2023 11:31
@alextreme
Copy link
Member

Fails due to conflicting migrations after merging in #486

@vaszig vaszig force-pushed the issue/860-reduce-product-summary-max-length branch from 572087f to ae4be7f Compare February 22, 2023 07:50
@codecov-commenter
Copy link

Codecov Report

Merging #482 (d815799) into develop (6d89fcb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #482   +/-   ##
========================================
  Coverage    96.50%   96.51%           
========================================
  Files          512      514    +2     
  Lines        18493    18529   +36     
========================================
+ Hits         17847    17883   +36     
  Misses         646      646           
Impacted Files Coverage Δ
src/open_inwoner/pdc/models/product.py 89.43% <ø> (ø)
..._inwoner/pdc/migrations/0049_auto_20230222_0901.py 100.00% <100.00%> (ø)
...woner/pdc/migrations/0050_alter_product_summary.py 100.00% <100.00%> (ø)
src/open_inwoner/pdc/tests/test_data_migrations.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin
Copy link
Contributor

Merging this as it is green and I need to rebase on it and use as migration dependency.

@Bartvaderkin Bartvaderkin merged commit 6bc831e into develop Feb 22, 2023
@Bartvaderkin Bartvaderkin deleted the issue/860-reduce-product-summary-max-length branch February 22, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants