🎨 [#1139] login-screen validation-text #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made the style specific to the ID because there was a very dominant style that changes everything to width=100% Can be tested here: http://127.0.0.1:8000/accounts/register/ |
|
|
||
| /// Registration. | ||
|
|
||
| #registration-form .form__control label.label ul { |
There was a problem hiding this comment.
IIRC there was some sort of rule/method to not use element names in the selectors, something with specificity (hence why everything has class names matching the tags).
There was a problem hiding this comment.
@Bartvaderkin I've changed it now - it's a unique situation that i think only occurs on the Registration page. + it's not valid HTML to have a UL tag (=block) inside a label (=inline) - but this is quick fix for now.
Bartvaderkin
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue with overflowing UL's in registration view:
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/1139