Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1144] Fix/update birthday date format in mydata #476

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 16, 2023

No description provided.

@vaszig vaszig marked this pull request as draft February 16, 2023 15:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #476 (9745370) into develop (6107ac5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #476   +/-   ##
========================================
  Coverage    96.46%   96.46%           
========================================
  Files          506      506           
  Lines        18263    18300   +37     
========================================
+ Hits         17617    17654   +37     
  Misses         646      646           
Impacted Files Coverage Δ
src/open_inwoner/openzaak/documents.py 94.59% <ø> (ø)
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/views/profile.py 99.16% <100.00%> (+0.03%) ⬆️
src/open_inwoner/haalcentraal/tests/test_signal.py 100.00% <100.00%> (ø)
src/open_inwoner/haalcentraal/utils.py 91.04% <100.00%> (+1.04%) ⬆️
src/open_inwoner/accounts/forms.py 97.78% <0.00%> (ø)
src/open_inwoner/openzaak/models.py 97.82% <0.00%> (ø)
src/open_inwoner/accounts/views/cases.py 97.52% <0.00%> (ø)
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig marked this pull request as ready for review February 20, 2023 11:14
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it'd be better to parse the API data to Python data (eg: a Date), and then format that using Django's standard date localization.

@alextreme alextreme merged commit c478f15 into develop Feb 20, 2023
@alextreme alextreme deleted the fix/1144-fix-mydata-birthday-format branch February 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants