🎨 [#1131] Dropdown on mobile partly rendered off-screen #473
Conversation
jiromaykin
force-pushed
the
fix/1131-Dropdown-on-mobile-rendered-offscreen
branch
from
90f3c94
to
e56e08a
Compare
| @@ -11,7 +11,7 @@ | |||
| flex-direction: column; | |||
| padding: var(--spacing-medium) 0; | |||
| position: absolute; | |||
| left: 0; | |||
| right: 0; | |||
There was a problem hiding this comment.
I don't see a reason to revert this and remove the code below imo. Testing the mobile and desktop versions in the test envs I have the expected left and right results. Maybe the issue was created before the style updates these days?
There was a problem hiding this comment.
@vaszig I had only updated that for the mobile views in a different PR yes, but we still need this new PR to also make the alignment correct everywhere else (for desktops), as based on the actual design (see my description on top of this page).
There was a problem hiding this comment.
If this is what we want for the different size screens, the code looks good to me. @alextreme can you please give us your opinion?
Codecov Report
@@ Coverage Diff @@
## develop #473 +/- ##
========================================
Coverage 96.46% 96.46%
========================================
Files 506 506
Lines 18263 18263
========================================
Hits 17617 17617
Misses 646 646
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
issue in Taiga: #1131 Dropdown on mobile partly rendered off-screen
In the original design it already showed the drop down should have been aligned to the right:
(https://projects.invisionapp.com/share/Y211V6JRHPC4#/screens/470665006)