-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1109] Feature/update plan list view #462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vaszig
commented
Feb 7, 2023
•
edited
Loading
edited
- Status column shows 'Open' (open plan) or 'Afgerond' (expired plan)
- Openstaande acties shows the number of 'open' actions (if status is 'open' or 'approval') with the proper message ('Actie vereist')
alextreme
reviewed
Feb 8, 2023
alextreme
reviewed
Feb 8, 2023
Bartvaderkin
reviewed
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## develop #462 +/- ##
===========================================
+ Coverage 96.43% 96.46% +0.02%
===========================================
Files 495 505 +10
Lines 17664 18255 +591
===========================================
+ Hits 17034 17609 +575
- Misses 630 646 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
approved these changes
Feb 9, 2023
Discussed with Alex and added only one small fix concerning pagination to this PR because it's not yet merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.