Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1109] Feature/update plan list view #462

Merged
merged 7 commits into from
Feb 10, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 7, 2023

  • Status column shows 'Open' (open plan) or 'Afgerond' (expired plan)
  • Openstaande acties shows the number of 'open' actions (if status is 'open' or 'approval') with the proper message ('Actie vereist')

@vaszig vaszig marked this pull request as draft February 7, 2023 15:16
@vaszig vaszig marked this pull request as ready for review February 8, 2023 12:29
@vaszig vaszig marked this pull request as draft February 9, 2023 10:25
@vaszig vaszig marked this pull request as ready for review February 9, 2023 11:41
@vaszig vaszig marked this pull request as draft February 9, 2023 11:47
@vaszig vaszig marked this pull request as ready for review February 9, 2023 11:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #462 (a0f80bd) into develop (73137fd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
+ Coverage    96.43%   96.46%   +0.02%     
===========================================
  Files          495      505      +10     
  Lines        17664    18255     +591     
===========================================
+ Hits         17034    17609     +575     
- Misses         630      646      +16     
Impacted Files Coverage Δ
src/open_inwoner/plans/models.py 98.50% <100.00%> (+0.23%) ⬆️
src/open_inwoner/plans/tests/test_views.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/views.py 97.52% <100.00%> (+0.24%) ⬆️
src/open_inwoner/utils/validators.py 84.61% <0.00%> (-15.39%) ⬇️
src/open_inwoner/openzaak/models.py 97.82% <0.00%> (-2.18%) ⬇️
src/open_inwoner/openzaak/tests/factories.py 98.57% <0.00%> (-1.43%) ⬇️
.../open_inwoner/components/templatetags/file_tags.py 86.11% <0.00%> (-0.38%) ⬇️
src/open_inwoner/openzaak/admin.py 90.35% <0.00%> (-0.35%) ⬇️
src/open_inwoner/openzaak/notifications.py 95.12% <0.00%> (-0.34%) ⬇️
src/open_inwoner/openzaak/documents.py 94.59% <0.00%> (-0.08%) ⬇️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig
Copy link
Contributor Author

vaszig commented Feb 10, 2023

Discussed with Alex and added only one small fix concerning pagination to this PR because it's not yet merged in.

@alextreme alextreme merged commit 9e8c1bd into develop Feb 10, 2023
@alextreme alextreme deleted the feature/1109-update-plans-list-view branch February 10, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants