Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1079] Added 'x-origin-oin' and 'x-doelbinding' fields to HaalCentraalConfig for BRP API 1.3 #456

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #456 (a80c701) into develop (73137fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #456   +/-   ##
========================================
  Coverage    96.43%   96.43%           
========================================
  Files          495      496    +1     
  Lines        17664    17690   +26     
========================================
+ Hits         17034    17060   +26     
  Misses         630      630           
Impacted Files Coverage Δ
...haalcentraal/migrations/0002_auto_20230206_1511.py 100.00% <100.00%> (ø)
src/open_inwoner/haalcentraal/models.py 100.00% <100.00%> (ø)
src/open_inwoner/haalcentraal/tests/test_signal.py 100.00% <100.00%> (ø)
src/open_inwoner/haalcentraal/utils.py 90.00% <100.00%> (+0.90%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In orde wat mij betreft. Je zou nog wel kunnen aangeven dat beide opties alleen werken met Haal Centraal BRP v1.3 (we ondersteunen ook v2.0)

@Bartvaderkin
Copy link
Contributor Author

@alextreme bij deze toegevoegd

@alextreme
Copy link
Member

Top dankje!

@alextreme alextreme merged commit d59119f into develop Feb 7, 2023
@alextreme alextreme deleted the feature/1079-haalcentraal-config branch February 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants