Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1076] Fix/refactor case document upload form #445

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 2, 2023

This has to do only with the upload form functionality, the refactoring after adding the ZaakType configs.
The submission part is covered by the next task (taiga #1062).

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #445 (70354d4) into develop (0ea2953) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #445      +/-   ##
===========================================
+ Coverage    96.24%   96.28%   +0.03%     
===========================================
  Files          493      493              
  Lines        17380    17371       -9     
===========================================
- Hits         16728    16726       -2     
+ Misses         652      645       -7     
Impacted Files Coverage Δ
src/open_inwoner/openzaak/api_models.py 99.17% <ø> (-0.06%) ⬇️
src/open_inwoner/accounts/forms.py 97.77% <100.00%> (+0.03%) ⬆️
src/open_inwoner/accounts/views/cases.py 97.40% <100.00%> (-0.02%) ⬇️
src/open_inwoner/openzaak/catalog.py 59.71% <100.00%> (+0.62%) ⬆️
src/open_inwoner/openzaak/managers.py 86.95% <100.00%> (+1.95%) ⬆️
src/open_inwoner/openzaak/models.py 100.00% <100.00%> (ø)
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig requested review from Bartvaderkin and alextreme and removed request for alextreme and Bartvaderkin February 2, 2023 09:14
@vaszig vaszig marked this pull request as draft February 2, 2023 11:17
@vaszig vaszig marked this pull request as ready for review February 2, 2023 12:07
@vaszig vaszig marked this pull request as draft February 2, 2023 14:41
@vaszig vaszig marked this pull request as ready for review February 2, 2023 15:56
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Neat!

@alextreme alextreme merged commit 3d5c873 into develop Feb 2, 2023
@alextreme alextreme deleted the fix/1076-refactor-case-document-upload branch February 2, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants