Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#976] Cleanup some selenium traces #407

Merged
merged 2 commits into from
Jan 2, 2023
+3 −6
Merged

[#976] Cleanup some selenium traces #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0343980
[#976] Renamed a test mixin
Jan 2, 2023
2235264
[#976] Removed lingering selenium setting
Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/open_inwoner/conf/dev.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@

TWO_FACTOR_PATCH_ADMIN = False

# django-selenium-login needs an arbitrary and fast page to grab cookies
SELENIUM_LOGIN_START_PAGE = "/admin/password_reset/"

# Override settings with local settings.
try:
from .local import * # noqa
Expand Down
6 changes: 3 additions & 3 deletions src/open_inwoner/plans/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ def test_plan_action_status_not_your_action(self):
self.assertEqual(response.status_code, 404)


class _PlanActionStatusSeleniumMixin:
class _PlanActionStatusPlaywrightMixin:
def setUp(self) -> None:
super().setUp()

Expand All @@ -578,13 +578,13 @@ def setUp(self) -> None:


class ChromePlanActionStatusPlaywrightTests(
_PlanActionStatusSeleniumMixin, ActionsPlaywrightTests
_PlanActionStatusPlaywrightMixin, ActionsPlaywrightTests
):
pass


class FirefoxPlanActionStatusPlaywrightTests(
_PlanActionStatusSeleniumMixin, ActionsPlaywrightTests
_PlanActionStatusPlaywrightMixin, ActionsPlaywrightTests
):
@classmethod
def launch_browser(cls, playwright):
Expand Down