Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#964] Feature/first-last name validation #381

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 13, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #381 (b0b5ad5) into develop (286f061) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
+ Coverage    96.00%   96.03%   +0.03%     
===========================================
  Files          461      462       +1     
  Lines        14801    14923     +122     
===========================================
+ Hits         14209    14331     +122     
  Misses         592      592              
Impacted Files Coverage Δ
src/open_inwoner/accounts/forms.py 98.90% <100.00%> (+<0.01%) ⬆️
...ner/accounts/migrations/0052_auto_20221213_0758.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/models.py 97.77% <100.00%> (ø)
src/open_inwoner/accounts/tests/test_auth.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_contact_views.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
src/open_inwoner/utils/validators.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor style/consistency comments.

I do note the particular set of invalid characters seems a bit limited but I see in the ticket this was specifically asked for.

src/open_inwoner/accounts/tests/test_auth.py Outdated Show resolved Hide resolved
src/open_inwoner/accounts/tests/test_profile_views.py Outdated Show resolved Hide resolved
@alextreme
Copy link
Member

Thanks for this, better safe than sorry!

@alextreme alextreme merged commit b666b11 into develop Dec 13, 2022
@alextreme alextreme deleted the task-964-first-last-name-validation branch December 13, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants