[#911] Added configuration options and logic to hide unused functionality #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 8, 2022 11:01
…le page But only if Samenwerken(plans) isn't enabled (because Plans re-use part of the Action views and user interaction)
This catches the edge case where Plan's are disabled after users were assigned tasks so we can't link back to the plan
…aireStep UI/links when no published steps
Codecov Report
@@ Coverage Diff @@
## develop #371 +/- ##
===========================================
+ Coverage 96.51% 96.56% +0.04%
===========================================
Files 457 461 +4
Lines 14452 14629 +177
===========================================
+ Hits 13949 14126 +177
Misses 503 503
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alextreme
reviewed
Dec 12, 2022
| def clean(self): | ||
| super().clean() | ||
|
|
||
| if self.show_plans and not self.show_actions: |
alextreme
approved these changes
Dec 12, 2022
vaszig
approved these changes
Dec 12, 2022
|
@vaszig thanks, glad you double-checked 👍 |
|
@vaszig I don't see it here but I'm still interested about the migration feedback, but anyway, there are two because I was trying to make clean commits instead of piling everything into one. |
Yes, it's clear enough. It makes sense to have them separately according to the nice and clear functionality-based commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to do some interpretation on the ticket, because Actions are a thing with or without Plan/Samenwerken.
So I made it so there is an option to disable Samenwerken and remove it from menu but keep general Action functionality, and another option to also disable the general Actions (which requires disabled Plan).
Additionally there was an ask to hide QuestionaireStep (Zelfcheck) if there are no published QuestionaireStep's, which was more of a bug-fix then a feature request.
It might make sense to overview the code per-commit as they are reasonably clean.