[#948] Harden fetch_roles_for_case_and_bsn() to work with e-Suite
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-Suite doesn't support query on both zaak and BSN
Bartvaderkin
commented
Dec 1, 2022
Comment on lines
269
to
+275
| m.get( | ||
| f"{ZAKEN_ROOT}rollen?zaak={self.zaak['url']}&omschrijvingGeneriek={RolOmschrijving.initiator}", | ||
| json=paginated_response([self.role]), | ||
| f"{ZAKEN_ROOT}rollen?zaak={self.zaak['url']}", | ||
| json=paginated_response([self.user_role, self.not_our_user_role]), | ||
| ) | ||
| m.get( | ||
| f"{ZAKEN_ROOT}rollen?zaak={self.zaak['url']}&betrokkeneIdentificatie__natuurlijkPersoon__inpBsn={self.user.bsn}", | ||
| json=paginated_response([self.role]), | ||
| f"{ZAKEN_ROOT}rollen?zaak={self.zaak['url']}&omschrijvingGeneriek={RolOmschrijving.initiator}", | ||
| json=paginated_response([self.user_role]), |
There was a problem hiding this comment.
Learning moment: requests.mocker matches on partial URLs, and in reverse order:
After making my initial changes to remove the BSN parameter I also I had to move the mock with both zaak and omschrijving below the one with only a zaak or it would always return the one with only zaak even if my request had the omschrijving parameter.
alextreme
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e-Suite doesn't support query on both zaak and BSN