Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ - Add tests for compile_dependencies. #346

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

svenvandescheur
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #346 (807fcaa) into develop (de5a4fe) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
+ Coverage    96.41%   96.43%   +0.01%     
===========================================
  Files          433      433              
  Lines        13140    13287     +147     
===========================================
+ Hits         12669    12813     +144     
- Misses         471      474       +3     
Impacted Files Coverage Δ
src/open_inwoner/openzaak/cases.py 67.85% <0.00%> (-4.53%) ⬇️
src/open_inwoner/openzaak/utils.py 92.59% <0.00%> (-2.41%) ⬇️
src/open_inwoner/openzaak/tests/test_cases.py 100.00% <0.00%> (ø)
.../open_inwoner/components/templatetags/card_tags.py 96.96% <0.00%> (ø)
src/open_inwoner/accounts/views/cases.py 99.30% <0.00%> (+0.04%) ⬆️
src/open_inwoner/openzaak/catalog.py 61.81% <0.00%> (+4.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme
Copy link
Member

I'm neutral about this one, @annashamray and @vaszig what do you think?

@annashamray
Copy link
Contributor

I don't mind but I think it should be run only if requirement of the bin/compile_dependencies.sh file is changed
We don't need it to run every time
@svenvandescheur could you add paths to the gh action config?

@vaszig
Copy link
Contributor

vaszig commented Nov 23, 2022

I am not very familiar with this kind of checking or optimizations but I agree with Anna concerning when we should run this.

Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the events which trigger the action

@alextreme alextreme merged commit 94de385 into develop Nov 28, 2022
@alextreme alextreme deleted the validate_dependencies branch November 28, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants